feat: allow hogql property queries in replay filtering #26176
Conversation
| @@ -132,7 +132,7 @@ export const universalFiltersLogic = kea<universalFiltersLogicType>([ | |||
| newValues.push(newFeatureFlagFilter) | |||
| } else { | |||
| const propertyType = | |||
| item.propertyFilterType ?? taxonomicFilterTypeToPropertyFilterType(taxonomicGroup.type) | |||
| item?.propertyFilterType ?? taxonomicFilterTypeToPropertyFilterType(taxonomicGroup.type) | |||
There was a problem hiding this comment.
hogql property filters don't have an item so this needs to be slightly safer
| @@ -144,6 +147,7 @@ const RecordingsUniversalFilterGroup = (): JSX.Element => { | |||
| onRemove={() => removeGroupValue(index)} | |||
| onChange={(value) => replaceGroupValue(index, value)} | |||
| initiallyOpen={allowInitiallyOpen} | |||
| metadataSource={{ kind: NodeKind.RecordingsQuery }} | |||
There was a problem hiding this comment.
we need something here to correct the autocomplete
There was a problem hiding this comment.
I need a query runner in python for the recordings query
| @@ -120,6 +120,8 @@ export function convertUniversalFiltersToRecordingsQuery(universalFilters: Recor | |||
| actions.push(f) | |||
| } else if (isLogEntryPropertyFilter(f)) { | |||
| console_log_filters.push(f) | |||
| } else if (isHogQLPropertyFilter(f)) { | |||
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
Size Change: +110 B (+0.01%) Total Size: 1.16 MB ℹ️ View Unchanged
|
| filter = SessionRecordingsFilter(request=request, team=self.team) | ||
| self._maybe_report_recording_list_filters_changed(request, team=self.team) | ||
| return list_recordings_response(filter, request, self.get_serializer_context()) | ||
| use_query_type = (request.GET.get("as_query", "False")).lower() == "true" |
There was a problem hiding this comment.
let's the API client declare which processing version it accepts so we can test the new mechanism with a slow rollout
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
@pauldambra is this ready for review? |
i got over confident at one point and then realised it wasn't done 🙈 will re-tag folk when i've resolved things |
we don't allow people to add hogql property filters in replay but we could
this PR
## todo
QueryRunnerforRecordingsQueryhogql filtering